[CSSimplify] Account for the fact that variadic generic parameters co… #64601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be specialized If generic parameter comes from a variadic type declaration it's possible that it got specialized early and is no longer represented by a pack expansion type. For example, consider expression - `Test<Int>(42)` where `Test<each T>` and the initializer is declared as `init(_: repeat each T)`. Although declaration based information reports parameter at index 0 as variadic generic the call site specializes it to `Int`. Resolves: rdar://107151854
|
@swift-ci please test |
slavapestov
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uld be specialized
If generic parameter comes from a variadic type declaration it's possible
that it got specialized early and is no longer represented by a pack expansion type.
For example, consider expression -
Test<Int>(42)whereTest<each T>andthe initializer is declared as
init(_: repeat each T). Although declaration basedinformation reports parameter at index 0 as variadic generic the call site specializes
it to
Int.Resolves: rdar://107151854