Skip to content

[interop][SwiftToCxx] do not error out on -Wnon-modular-include-in-fr… #64756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Mar 30, 2023

…amework-module clang diagnostic when importing the generated header as part of a framework back into C++ via a Clang module

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Mar 30, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners March 30, 2023 03:31
@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

waiting on swiftlang/llvm-project#6556 before testing.

@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

ptrauth.h isn't modularized in Apple/github/clang, so avoid importing it for non-arm64e code.

…amework-module clang diagnostic when importing the generated header as part of a framework back into C++ via a Clang module
@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

@swift-ci please test source compatibility

1 similar comment
@hyp
Copy link
Contributor Author

hyp commented Mar 30, 2023

@swift-ci please test source compatibility

@hyp hyp merged commit 2b31287 into swiftlang:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant