Skip to content

[interop] mark C++ virtual functions as unavailable in Swift #65045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

[interop] mark C++ virtual functions as unavailable in Swift #65045

merged 1 commit into from
Apr 11, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Apr 10, 2023

They're not yet supported

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Apr 10, 2023
@hyp hyp requested a review from ravikandhadai April 10, 2023 18:52
@hyp hyp requested review from zoecarver and egorzhdan as code owners April 10, 2023 18:52
@hyp
Copy link
Contributor Author

hyp commented Apr 10, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Apr 10, 2023

@swift-ci please test source compatibility

ravikandhadai
ravikandhadai approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ravikandhadai ravikandhadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hyp

@hyp
Copy link
Contributor Author

hyp commented Apr 10, 2023

@swift-ci please test macOS platform

@hyp hyp merged commit d563b58 into swiftlang:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravikandhadai ravikandhadai ravikandhadai approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @ravikandhadai