[Runtime] Ensure we *always* generate names for ObjC classes. #65140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
mikeash
approved these changes
Apr 13, 2023
stdlib/public/runtime/Metadata.cpp
Outdated
| // Prefix plus 16 hex digits plus NUL | ||
| size_t allocationSize = strlen(EMERGENCY_PREFIX) + 16 + 1; | ||
| auto nameBuf = (char *)swift_slowAlloc(allocationSize, 0); | ||
| snprintf(nameBuf, allocationSize, |
There was a problem hiding this comment.
Can we count on asprintf to be available whenever ObjC interop is enabled? That would make this a bit less scary.
There was a problem hiding this comment.
We probably could at that. I always forget about asprintf(). I'll update the PR to use that.
If something fails while trying to generate a name for an ObjC class, we fall back to a generated name based on the metadata pointer. This ensures that we won't crash, and if the name turns up in the debugger or somewhere it should be obvious that something went wrong. rdar://107718586
al45tair
force-pushed
the
eng/PR-107718586
branch
from
8fe1cf4 to
2f6baac
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something fails while trying to generate a name for an ObjC class, we fall back to a generated name based on the metadata pointer. This ensures that we won't crash, and if the name turns up in the debugger or somewhere it should be obvious that something went wrong.
rdar://107718586