[NFC] CS: Misc minor debug output tweaks #65246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don’t test this anywhere, do we? |
xedin
approved these changes
Apr 18, 2023
|
@swift-ci please smoke test macOS |
|
I could have just searched for the flag to find the tests but instead I had to launch a smoke test 🤦🏼♂️ |
* Use fancy arrows (`→`) because they are distinct from and shorter than `->`, and fancier. * We have two ways of demarcating locators: `@ <locator>` and `[[<locator>]];`. Stick to the first, which is shorter and clearer. * 'attempting type variable' → 'attempting binding'. *Bindings* are attempted, not type variables. * `considering ->` → `considering:`. I think a colon is semantically more fit and makes things easier to read if the considered constraint has arrows in its description or types. It’s also shorter this way.
AnthonyLatsis
force-pushed
the
nfc-debug-constraints
branch
from
5ef4f67 to
82ac932
Compare
I think I will leave this for another time, if that’s fine 🙂 |
|
@swift-ci please smoke test |
|
Yeah, that’s totally fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
→) because they are distinct from and shorter than->, and fancier.@ <locator>and[[<locator>]];. Stick to the first, which is shorter and clearer.considering ->→considering:. I think a colon is semantically more fit and makes things easier to read if the considered constraint has arrows in its description or types. Also, it’s shorter this way.