[5.9 🍒][Dependency Scanning] Consider scanned module name a part of the scanning context (hash) #65416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning context (hash) As well as a couple of additional frontend options that seem like they may impact scanning result. Resolves rdar://108464467
|
@swift-ci test |
nkcsgexi
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65415
As well as a couple of additional frontend options that seem like they may impact scanning result.
• Release: Swift 5.9
• Explanation: To have these options missing from the dependency scanning context hash means that clients that may be running multiple concurrent scans on targets/modules that have identical command-lines other than the module name would encounter concurrency issues due to not isolating their respective scans' state.
• Scope of Issue: Scanner crashes when scanning multiple source modules simultaneously where the scanner invocations only differ in module name.
• Origination: Synchronization of concurrent scans was recently moved to the scanner itself, from the client (SwiftDriver).
• Risk: Zero risk to implicit module builds, minimal risk to explicit module builds - this change is more restrictive than we were before and will result in more distinct scanning contexts
• Automated Testing: Added unit test that verifies scanning hash difference for relevant use-cases
Resolves rdar://108464467