[5.9] [Macros] "Subsume" the initializer when an accessor macros adds non-observing accessors #65502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DougGregor
commented
Apr 28, 2023
DougGregor
commented
- Explanation: When an accessor macro adds a non-observing accessor to a property, it subsumes the initializer. Model this using the same scheme as when a property wrapper subsumes the initializer of a stored property when it turns it into a computed property. This eliminates a problem where applying an accessor macro to a stored property was preventing inference of the property type from an initializer, the prior fix for which had introduced cyclic references. This property modeling addresses both issues at once.
- Scope: Affects the handling of stored property initializers with accessor macros.
- Risk: Low, leverages existing handling of subsumed initializers (from property wrappers) for accessor macros.
- Issue: rdar://108565923
- Original pull request: [Macros] "Subsume" the initializer when an accessor macros adds non-observing accessors #65501
…add accessors" This reverts commit ef7970b. We shouldn't need this.
Fixes rdar://108565923.
…bservers When an accessor macro adds a non-observing accessor to a property, it subsumes the initializer. We had previously modeled this as removing the initializer, but doing so means that the initializer could not be used for type inference and was lost in the AST. Explicitly mark the initializer as "subsumed" here, and be more careful when querying the initializer to distinguish between "the initializer that was written" and "the initializer that will execute" in more places. This distinction already existed at the pattern-binding level, but not at the variable-declaration level. This is the proper fix for the circular reference issue described in rdar://108565923 (test case in the prior commit).
|
@swift-ci please test |
hborla
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.