Remove an obsolete workaround for error variables. #65505
Merged
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a revert of the workaround for creating debug info for error variables in b2109ab, while leaving the test added back then in place. The compiler is now emitting debug info for the error pattern binding as it's supposed to and after the recent migration to stricter debug scope generation, there are now situations where the variable added for the workaround and the correct one are in conflict. rdar://108576484 (cherry picked from commit 0668289)
|
@swift-ci test |
|
@swift-ci test windows |
fredriss
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of the workaround for creating debug info for error variables in b2109ab, while leaving the test added back then in place. The compiler is now emitting debug info for the error pattern binding as it's supposed to and after the recent migration to stricter debug scope generation, there are now situations where the variable added for the workaround and the correct one are in conflict.
rdar://108576484
(cherry picked from commit 0668289)