Skip to content

[stdlib] _Int128: fix invalid overflow crash #65703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023
Merged

[stdlib] _Int128: fix invalid overflow crash #65703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/public/core/Int128.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ extension _${U}Int128: FixedWidthInteger {
by rhs: Self
) -> (partialValue: Self, overflow: Bool) {
% if signed:
let isNegative = (self._isNegative != rhs._isNegative)
let isNegative = (self._isNegative != rhs._isNegative && self != .zero && rhs != .zero)
let (p, overflow) = self.magnitude.multipliedReportingOverflow(
by: rhs.magnitude)
let r = _Int128(bitPattern: isNegative ? p._twosComplement : p)
Expand All @@ -281,7 +281,7 @@ extension _${U}Int128: FixedWidthInteger {
by other: UInt64
) -> (partialValue: Self, overflow: Bool) {
% if signed:
let isNegative = self._isNegative
let isNegative = self._isNegative && self != .zero && other != .zero
let (p, overflow) = self.magnitude.multipliedReportingOverflow(by: other)
let r = _Int128(bitPattern: isNegative ? p._twosComplement : p)
return (r, overflow || (isNegative != r._isNegative))
Expand Down