[5.9🍒] consuming cannot be applied to nonescaping closures #65707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to SE-377:
consuming cannot be applied to parameters of nonescaping closure type, which by their nature are always borrowed:
// ERROR: cannot `consume` a nonescaping closure
func foo(f: consuming () -> ()) {
}
This commit implements the error message.
rdar://108388132
(cherry picked from commit 32e8987)
gottesmm
approved these changes
May 5, 2023
|
@swift-ci please test |
tbkka
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: The net effect of this change is to tailor an error message about
consumingon a Copyable type that we know is always going to be invalid. This error is specifically called out in SE-377 as something that's not allowed, so it's even emitted when using-enable-experimental-feature NoImplicitCopy, which is why a bunch of tests are now removed.• Risk: None. It just changes a small subset of an existing error messages so they use a different message.
• Original PR: #65691
• Reviewed By: @gottesmm
• Testing: regression test included
• Resolves: rdar://108388132