[move-only] Ensure that if we have an allocation that isn't fully initialized (and DI errors on it as such), the move checkers do not run on the allocation. #65773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
…tialized (and DI errors on it as such), the move checkers do not run on the allocation. Previously we would crash. Since we are relatively late in 5.9, my solution is to just turn off the move checker on functions whenever DI would emit an error. If we were earlier in the development cycle, then I would make the error be a per allocation change. rdar://108993297
gottesmm
force-pushed
the
pr-ca1d38387d2ede83e74c099e78e89c8eeaba81ba
branch
from
c2541d5 to
d413b24
Compare
|
@swift-ci smoke test |
|
Made the change smaller/simpler so that I don't have to touch the module format. |
|
@swift-ci smoke test |
jckarter
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would crash.
The methodology here is that I added a flag to alloc_stack and alloc_box called had_di_error. DI if it emits an error on said alloc_stack/alloc_box will set the flag. If the move checker sees that flag then:
rdar://108993297