[CodeCompletion] Don’t crash when completing in a parameter position that only constraints one of two primary associated protocol types #65847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that only constraints one of two primary associated protocol types When completing, we call `getExistentialType` on the contextual type to get a nice and concise description of the contextual parameter’s type that doesn’t contain archetypes and which we can also serialize into a USR so we are able to calculate type relations for code completion results from the code completion cache. When completing in a position that has a contextual type which only constrains one of two primary associated protocol types, this fails because `getExistentialType` (which calls `getDependentUpperBounds`) tries to form a `ParameterizedProtocolType`, which fails since not all primary associated types have been constrained. AFAICT the fix here is to just fall back to the default behavior of returning the plain protocol type instead of `abort`ing. rdar://108835466
ahoppen
requested review from
bnbarham,
rintaro,
hborla and
slavapestov
as code owners
|
@swift-ci Please smoke test |
Comment on lines
+727
to
+736
| // If we have constrained all primary associated types, create a | ||
| // parameterized protocol type. During code completion, we might call | ||
| // `getExistentialType` (which calls this method) on a generic parameter | ||
| // that doesn't have all parameters specified, e.g. to get a consise | ||
| // description of the parameter type to the following function. | ||
| // | ||
| // func foo<P: Publisher>(p: P) where P.Failure == Never | ||
| // | ||
| // In that case just add the base type in the default branch below. | ||
| if (argTypes.size() == primaryAssocTypes.size()) { |
There was a problem hiding this comment.
Note: This makes sense in general because this method is not guaranteed to return a supremum (existentials are not that expressive at least yet), and so does ArchetypeType::getExistentialType.
slavapestov
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When completing, we call
getExistentialTypeon the contextual type to get a nice and concise description of the contextual parameter’s type that doesn’t contain archetypes and which we can also serialize into a USR so we are able to calculate type relations for code completion results from the code completion cache.When completing in a position that has a contextual type which only constrains one of two primary associated protocol types, this fails because
getExistentialType(which callsgetDependentUpperBounds) tries to form aParameterizedProtocolType, which fails since not all primary associated types have been constrained.AFAICT the fix here is to just fall back to the default behavior of returning the plain protocol type instead of
aborting.rdar://108835466