[5.9] MoveOnlyAddressChecker: Reintroduce debug info for variables after reassignment #66023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assignment. After a value is consumed, we emit a `debug_value undef` to indicate that the variable value is no longer valid to the debugger. However, once a value is reassigned, it becomes valid again, so emit a `debug_value %original_address` to reassociate the variable with the valid memory location. rdar://109218404
|
@swift-ci Please test |
tbkka
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rdar://109218404
• Explanation: When a noncopyable binding's value is consumed, we mark the variable as absent in debug info so that the debugger does not attempt to show the expired value. This patch reintroduces the variable in cases where it's reassigned and becomes valid again.
• Scope of Issue: Improves debug info.
• Origination: Quality of implementation of debug info for the new noncopyable types feature.
• Risk: low -- improves debug info for a new feature. Should have no impact on existing code that doesn't adopt the noncopyable types feature.
• Reviewed By: @gottesmm
• Automated Testing: Swift CI