[5.9🍒] handle parsing ~ before a type in more places
#66943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's still an error in most places, but now we don't give as bizzare of an error message. rdar://110421020
|
@swift-ci please test |
tbkka
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: If you wrote
~SomeTypein places like awhereclause or in the angle brackets of a generic parameter, you'd get rather bizarre error messages indicating a failure to parse. While it's meant to still stay illegal to write such a type there, now we specifically emit an error to the effect that you can't write a suppressed type there.• Risk: Very Low. only specially recognizes an illegal character at the start of parsing a type to emit a diagnostic.
• Original PR: #66942
• Reviewed By:
• Testing: regression tests included
• Resolves: rdar://110421020