Skip to content

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 29, 2023

Cherry-pick #67007 into release/5.9

  • Explanation: Implement special member functions in PluginSearchOtpion. They were not properly implemented. ExternalUnion requires explicit destruct() call to destruct the payload. This fixes a memory leak when plugin search frontend options are specified.
  • Scope: Search path option
  • Risk: Low. Just fixing a memory leak without changing other code
  • Testing: Leak sanitizer enabled PR testing passed
  • Issue: rdar://111064325
  • Reviewer: Ben Barham (@bnbarham)

Destructor of PluginSearchOption wasn't properly implemented.
Implement special member functions.

rdar://111064325
(cherry picked from commit 21d1e2e)
@rintaro rintaro requested a review from a team as a code owner June 29, 2023 13:39
@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2023

@swift-ci Please test

@rintaro rintaro merged commit fc0ddf2 into swiftlang:release/5.9 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants