[IRGen] Visit members generated by peer macros in ClassDataBuilder. #67314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by calling getAllMembers() instead of getMembers() in TypeMemberVisitor::visitImplementationMembers.
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test macOS platform |
in evaluateMembersRequest.
|
@swift-ci please smoke test |
xedin
approved these changes
Jul 17, 2023
ktoso
approved these changes
Jul 17, 2023
|
Thanks for the fix @hborla |
|
@swift-ci please smoke test |
ktoso
reviewed
Jul 17, 2023
| @@ -681,6 +681,7 @@ void swift::checkDistributedActorProperties(const NominalTypeDecl *decl) { | |||
| if (id == C.Id_actorSystem || id == C.Id_id) { | |||
| prop->diagnose(diag::distributed_actor_user_defined_special_property, | |||
| id); | |||
| prop->setInvalid(); | |||
|
|
@swift-ci please smoke test Linux |
3 similar comments
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassDataBuilderwas skipping members generated by peer macros becauseTypeMemberVisitor::visitImplementationMemberscalledgetMembers()instead ofgetAllMembers().Resolves rdar://112217268 and the runtime crash that was hit in #67289