[sema] Ban user created read/set accessor that produce noncopyable types #67546
+108
−682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes. The reason why we are doing this is that this combination of read/set forces the compiler to emit a copy if we want to emit a modify operation. The reason why we are forced to emit such a copy is that: 1. _read provides a guaranteed value in memory 2. performing a modify requires an owned value in memory. This together implies that the only way we can do this is to copy from the _read into temporary memory. But we have a noncopyable type so we can't do this. rdar://112915525
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why we are doing this is that this combination of read/set forces the compiler to emit a copy if we want to emit a modify operation.
The reason why we are forced to emit such a copy is that:
This together implies that the only way we can do this is to copy from the _read into temporary memory. But we have a noncopyable type so we can't do this.
rdar://112915525