[AutoDiff] Emit a diagnostic for non-differentiable active values #67697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some values we cannot compute types for differentiation (for example, tangent vector type), so it is better to diagnose them earlier. Otherwise we hit assertions when generating code for such invalid values. The LIT test is a reduced reproducer from the issue swiftlang#66996. Before the patch the compiler crashed while trying to get a tangent vector type for the following value (partial_apply): %54 = function_ref @$s4null1o2ffSdAA1FV_tFSdyKXEfu0_ : $@convention(thin) @Substituted <τ_0_0> (@inout_aliasable Double) -> (@out τ_0_0, @error any Error) for <Double> %55 = partial_apply [callee_guaranteed] %54(%2) : $@convention(thin) @Substituted <τ_0_0> (@inout_aliasable Double) -> (@out τ_0_0, @error any Error) for <Double> Now we emit a diagnostic instead. The patch resolves issues swiftlang#66996 and swiftlang#63331.
|
Tagging @BradLarson |
|
@swift-ci please test |
rxwei
reviewed
Aug 3, 2023
| @@ -1804,6 +1804,11 @@ bool PullbackCloner::Implementation::run() { | |||
| DominanceOrder domOrder(original.getEntryBlock(), domInfo); | |||
| // Keep track of visited values. | |||
| SmallPtrSet<SILValue, 8> visited; | |||
| // Also check for differentiable for all active values | |||
There was a problem hiding this comment.
Not sure I understand this comment. The two lines of code below are just obtaining the protocol and the module and don't seem related to the comment.
There was a problem hiding this comment.
Right, this comment is more suitable next to the actual check below.
|
@swift-ci please test |
|
There is quite a lot of LIT test with tuples being incorrectly (?) diagnosed as non-differentiable. I will check them and update the patch. |
|
@asavonic Because some components are non-differentiable? |
…ocol Types like `tuple` do not conform to the differentiable protocol, but they are handled in the compiler as special cases. getTangentSpace should work for all these types, and discard truly non-differentiable types.
|
@swift-ci please test |
rxwei
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some values we cannot compute types for differentiation (for example, tangent vector type), so it is better to diagnose them earlier. Otherwise we hit assertions when generating code for such invalid values.
The LIT test is a reduced reproducer from the issue #66996. Before the patch the compiler crashed while trying to get a tangent vector type for the following value (partial_apply):
Now we emit a diagnostic instead.
The patch resolves issues #66996 and #63331.