[5.9.0] Update macro help in driver and diagnostics #67887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the format of the option and semantics. rdar://113646544
bnbarham
added
🍒 release cherry pick
|
@swift-ci please test |
This is a very large diagnostic, where the second half is mostly aimed at macro authors rather than clients. Cut it down to the base diagnostic. Resolves rdar://113646544.
bnbarham
force-pushed
the
5.9.0-update-macro-help
branch
from
0ba4dac to
1243036
Compare
|
@swift-ci please test |
airspeedswift
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #67834 and #67885 into release/5.9.0
-load-plugin-executablecompiler option is the primary supported way of using macro plugin. SwiftPM uses this when developers use.macro()target. The driver help text should clarify the format and the semantics of the arguments. The diagnostic shouldn't mention-plugin-pathor-load-plugin-library.