[ConstraintSystem] Fix locator builder directlyAt
#68013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hasEmptyPath` in locator builder context means that there are no new elements added which is different from the materialized locator, `directlyAt` has to use `!last()` to check whether or not there are any elements in the path of this builder.
|
There is only one user of this method at the moment so no test case unfortunately. Discovered while working on key path related changes with @amritpan |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasEmptyPathin locator builder context means that there are no new elementsadded which is different from the materialized locator,
directlyAthas to use!last()to check whether or not there are any elements in the path of this builder.