[rebranch] Fix recently added merge function test #68041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
This test was added to test a specific failure (merging functions with casted return types). Is there a copy of this test case in another file? |
|
Maybe we only need to remove the -opaque-pointers flag? |
|
The test was added here: #67964 yes, I don’t think we should remove this test—there doesn’t seem to be a copy elsewhere |
|
Ah okay, I was assuming |
Opaque pointers are always enabled on rebranch. Rename the test to better represent what it's testing.
bnbarham
force-pushed
the
remove-opaque-test
branch
from
60f9fe8 to
993c0df
Compare
|
@swift-ci please test |
eeckstein
approved these changes
Aug 22, 2023
bnbarham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was just added in main, but rebranch has opaque pointers enabled all the time and there's already a
merge_func.lltest.