[OpaqueValues] Fix closure handling. #68054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, always use indirect convention for types with packs. This is motivated by the fact that getting from/setting to a pack currently requires addresses which aren't materialized for tuples. In the fullness of time, these values should be direct in opaque values mode, but for now it can be postponed.
nate-chandler
force-pushed
the
opaque-values/20230821/2/closures
branch
2 times, most recently
from
186baa4 to
13542dc
Compare
Rewrote and tested all currently emittable variations of closure handling for opaque values.
nate-chandler
force-pushed
the
opaque-values/20230821/2/closures
branch
from
13542dc to
ff30221
Compare
|
@swift-ci please test |
|
@swift-ci please benchmark |
|
@swift-ci please test source compatibility |
|
Timeouts and a UPASS in the debug source compat failure. |
|
@swift-ci Please Test Source Compatibility Debug |
1 similar comment
|
@swift-ci Please Test Source Compatibility Debug |
|
Same source compat failures as in rdar://114339248 . |
atrick
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote and tested all currently emittable variations of closure handling for opaque values.
In order to do that, made all types with packs be indirect even in opaque values for now. This is motivated by the fact that getting from/setting to a pack currently requires addresses which aren't materialized for tuples. In the fullness of time, these values should be direct in opaque values mode, but for now it can be postponed.