Skip to content

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Aug 29, 2023

This test occasionally fails due apparently not loading libswiftFoundation. The test relies on a bridging header to import the Foundation module, which seems iffy. Explicitly import Foundation instead.

rdar://114590327

This test occasionally fails due apparently not loading libswiftFoundation. The test relies on a bridging header to import the Foundation module, which seems iffy. Explicitly import Foundation instead.

rdar://114590327
@mikeash mikeash requested a review from nate-chandler August 29, 2023 13:52
@mikeash mikeash marked this pull request as ready for review August 29, 2023 13:52
@mikeash
Copy link
Contributor Author

mikeash commented Aug 29, 2023

@nate-chandler You added this test in #65306, can you confirm that the lack of import Foundation isn't actually part of what's being tested? I want to make sure I'm not accidentally "fixing" the test so it doesn't actually test what it's supposed to.

@mikeash
Copy link
Contributor Author

mikeash commented Aug 29, 2023

@swift-ci please test

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yeah, that's not part of what the test is intended to verify.

@mikeash
Copy link
Contributor Author

mikeash commented Aug 29, 2023

Great! I didn't think so, but wanted to be sure.

@mikeash mikeash merged commit 9dbb9e4 into swiftlang:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants