Serialization: Tagged compilers should rebuild modules from swiftinterface under the resource-dir #68382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
I think limiting the behavior to untagged compilers makes the most sense to me. |
…e builds There is some special logic for loading modules from under the resource-dir. In this case, if there's a swiftmodule next to the swiftinterface we refuse to rebuild the module from the swiftinterface. It was designed to catch misconfigurations, either locally if we forget to rebuild the stdlib from source or at deployement. It has been causing issues recently with LLDB and other tools. Let's keep this behavior only for the local scenario by limiting it to untagged compilers. This restriction aligns well with the strict compiler tag check for swiftmodule compatibility.
xymus
force-pushed
the
serial-special-case-here
branch
from
03921e8 to
52f2cc3
Compare
|
Updated it to use the compiler tag instead of debug vs release build. @swift-ci Please smoke test |
xymus
changed the title
tshortli
approved these changes
Sep 7, 2023
|
Oh thank you, this is very useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some special logic for loading modules from under the resource-dir. In this case, if there's a swiftmodule next to the swiftinterface we refuse to rebuild the module from the swiftinterface. It was designed to catch misconfigurations, either locally if we forget to rebuild the stdlib from source or at deployement.
It has been causing issues recently with LLDB and other tools. Let's keep this behavior only for the local scenario by limiting it to untagged compilers. Leaving tagged/distributed compilers to rebuild more modules from the swiftinterface. This restriction aligns with the strict compiler tag check for swiftmodule compatibility which is applied by tagged compilers only.