ModuleInterface: Fix inheritance clauses in lazily emitted swiftinterfaces #68384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a `.swiftinterface` emitted in lazy typechecking mode would fall back on printing the `TypeRepr` of entries in the inheritance clause of a declaration since inherited types could be unresolved.
Previously, `usesFeatureRethrowsProtocol()` could mistakenly return false in lazy typechecking mode since the types in an inheritance clause might not have been resolved yet.
Previously, conformances inherited through a base class could be missed in lazy typechecking mode if types in the inheritance clause were not already resolved.
…ormances. Previously, indirect public conformances provided by conforming to an internal protocol could be skipped in a `.swiftinterface` in lazy typechecking mode since inherited types might not be resolved before collecting the indirect conformances.
… conformances. Previously, unsatisfiable conformances could be omitted from emitted `.swiftinterface` files in lazy typechecking mode since inherited types might be unresolved when gathering the conformances. Adding these test cases also revealed that serialization restrictions needed to be relaxed in order to accomodate unsatisfiable conformances.
tshortli
requested review from
artemcm,
slavapestov,
hborla and
xedin
as code owners
|
@swift-ci please test |
xymus
approved these changes
Sep 7, 2023
tshortli
deleted the
emit-module-lazy-typecheck-inherited-protocol-printing
branch
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 14, 2023
One of the request triggers added to `ConformanceLookupTable` in swiftlang#68384 can cause circular request evaluation. Revert the request trigger since it doesn't appear to be necessary for the test cases introduced in that PR. Resolves rdar://115314044
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 14, 2023
One of the request triggers added to `ConformanceLookupTable` in swiftlang#68384 can cause circular request evaluation. Revert the request trigger since it doesn't appear to be necessary for the test cases introduced in that PR. Resolves rdar://115314044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lazy typechecking mode, nothing eagerly resolves the types in the inheritance clauses of declarations. This was causing swiftinterface printing to fail in a variety of ways. These fixes ensure inherited types are resolved on-demand by interface printing logic.
Builds on top of #68338.