[5.10] IRGen: fix emission of constant single-case enums without payload #68623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up of swiftlang#68516 which didn't handle the no-payload case correctly Fixes a compiler crash rdar://115666971
|
@swift-ci test |
eeckstein
changed the title
tbkka
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This is a follow-up of [5.10] IRGen: fix emission of constant single-case enums #68521 which didn't handle the no-payload case correctly. It fixes a compiler crash when a single-case enum without a payload is put into a global variable, or an array literal contains such an enum. The first fix only handled single-case enums with payloads, but misses the non-payload variant.
Issue: rdar://115666971
Risk: Low. The change only affects single-case enums without payloads - which is quite rare.
Testing: With a regression test.
Reviewer: @aschwaighofer
Main branch PR: IRGen: fix emission of constant single-case enums without payload #68616