[stdlib] remove pointer conversion from inlined runtime code #68715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an inout-to-pointer conversion for runtime code that is completely expressed in Swift.
|
@swift-ci please test |
Catfish-Man
approved these changes
Sep 22, 2023
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an inout-to-pointer conversion for inlinable runtime code that is completely expressed in Swift.
If pointer conversions were to be completely disallowed in pure Swift code, the presence of this pointer conversion in a pre-existing standard library would prevent the compiler from building from scratch.
After this change, we get the same generated assembly as before when compiling in release mode.
Addresses rdar://115912430