Tests: Re-design skip-function-bodies.swift test #68758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skip-function-bodies.swift test previously relied on `-emit-sorted-sil` to control the order of SIL emission for matching CHECK: lines. I found that this made the test too difficult to evolve, so I've re-written the test to instead check SILGen's output by extracting just the `string_literal` lines and then sorting them. This makes it much more straightforward to add new test cases at the right location in the file. There are a number of additional improvements to the test: - SILGen without any function body skipping is now checked as a baseline to ensure that all the checks are in the right order. Previously, most of the negative CHECK lines were not properly ordered in the file, so they could have missed regressions. - Every declaration in the test has a set of exhaustive CHECK lines covering each of the outputs explicitly. While more verbose, it should be clearer what is expected for every declaration. - Module interfaces are emitted with the proper flags and are typechecked to verify they are valid. - Superfluous diagnostics (e.g. unused variables) have been minimized to improve the experience of debugging failures.
tshortli
force-pushed
the
rewrite-skip-function-bodies-test
branch
from
03c2c24 to
43e36cc
Compare
|
@swift-ci please smoke test and merge |
|
Reverting here since this broke Windows CI but was auto-merged anyways: #68770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skip-function-bodies.swift test previously relied on
-emit-sorted-silto control the order of SIL emission for matching CHECK: lines. I found that this made the test too difficult to evolve, so I've re-written the test to instead check SILGen's output by extracting just thestring_literallines and then sorting them. This makes it much more straightforward to add new test cases at the right location in the file.There are a number of additional improvements to the test: