[5.10] [Sema] Fix try/await handling for if/switch expressions
#68801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we allowed an attached `try` or `await` on an `if`/`switch` expression to cover the branches, which does not match what was proposed, and is especially harmful for multi-statement cases. Fix the effect handling logic such that we reset effect coverage for `if`/`switch` expressions similar to closures, but continue to maintain the state needed for rethrows checking. rdar://116066748
hamishknight
added
🍒 release cherry pick
|
@swift-ci please test |
bnbarham
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.10 cherry-pick of #68765
tryandawaitcould be used to "cover" throwing and async calls within the branches of anif/switchexpression. This patch fixes the issue such that we requiretryandawaitto appear on the effectful calls in the branches, and diagnose the use oftry/awaiton anif/switchexpression.if/switchexpressions