[5.10 🍒] Always disable requiring Foundation for '@objc' when building/typechecking interfaces #68914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
artemcm
force-pushed
the
510NoObjCRequiresFoundationInInterfaceTypecheck
branch
from
00088a0 to
78341b9
Compare
|
@swift-ci test |
nkcsgexi
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68913
• Release: Swift 5.10
• Explanation: Today, this (
-disable-objc-attr-requires-foundation-module) is an extra flag we add inInterfaceSubContextDelegateImpl::inheritOptionsForBuildingInterface, which does not seem right for all cases, such as explicit interface build and verify jobs, as it is not inherited from the parent invocation. It should instead just be the default for these frontend actions.• Scope of Issue: Explicit module builds invoke interface verification jobs which may hard fail upon encountering
@objcifFoundationmodule is not imported by the interface. This is not meant to be a hard error.• Risk: Minimal, this change sets the default to match behavior of implicit builds.
• Origination: Explicit Module Build feature development.
Resolves rdar://116008985