Skip to content

[embedded] Add a embedded Swift + typed throw test showcasing that we avoid existentials #68977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2023
Merged

[embedded] Add a embedded Swift + typed throw test showcasing that we avoid existentials #68977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4301862
[embedded] Add a embedded Swift + typed throw test showcasing that we…
kubamracek Oct 5, 2023
2b90200
[embedded] Add -O and -Osize variants in the typed throws test
kubamracek Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 97 additions & 0 deletions test/embedded/throw-typed.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
// RUN: %target-run-simple-swift(%S/Inputs/print.swift -enable-experimental-feature Embedded -enable-experimental-feature TypedThrows -parse-as-library -runtime-compatibility-version none -wmo -Xfrontend -disable-objc-interop) | %FileCheck %s
// RUN: %target-run-simple-swift(%S/Inputs/print.swift -O -enable-experimental-feature Embedded -enable-experimental-feature TypedThrows -parse-as-library -runtime-compatibility-version none -wmo -Xfrontend -disable-objc-interop) | %FileCheck %s
// RUN: %target-run-simple-swift(%S/Inputs/print.swift -Osize -enable-experimental-feature Embedded -enable-experimental-feature TypedThrows -parse-as-library -runtime-compatibility-version none -wmo -Xfrontend -disable-objc-interop) | %FileCheck %s

// REQUIRES: executable_test
// REQUIRES: optimized_stdlib
// REQUIRES: VENDOR=apple
// REQUIRES: OS=macosx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep forgetting whether we still need REQUIRES: asserts when -enable-experimental-feature flag is used or not, could you please double-check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some features need asserts, some don't (it's controlled in the Features.def file on a per feature basis). The ones used here don't need asserts.


public enum MyError : Error, Equatable {
case a
case b
case c(Int)
}

extension Int : Error {}

public func throwing(which: Int) throws(MyError) -> Int {
if which == 0 {
throw MyError.a
} else if which == 1 {
throw MyError.b
} else if which == 2 {
throw MyError.c(42)
}

return 123
}

public func throwing2() throws(Int) {
throw 42
}

public func catching() {
do {
try throwing(which: 0)
} catch let e as MyError {
print(e == .a ? "OK1" : "???")
}

do {
try throwing(which: 1)
} catch let e as MyError where e == .b {
print(e == .b ? "OK2" : "???")
} catch {
print("???")
}

do {
try throwing(which: 2)
} catch let e as MyError where e == .b {
print("???")
} catch {
print("OK3")
}

do {
try throwing(which: 2)
} catch let e as MyError {
if case .c(let n) = e {
print(n == 42 ? "OK4" : "???")
} else {
print("???")
}
} catch {
print("???")
}

do {
try throwing(which: 3)
print("OK5")
} catch {
print("???")
}

do {
try throwing2()
} catch {
print(error == 42 ? "OK6" : "???")
}
}

@main
struct Main {
static func main() {
catching()
}
}

// CHECK: OK1
// CHECK: OK2
// CHECK: OK3
// CHECK: OK4
// CHECK: OK5
// CHECK: OK6

// CHECK-NOT: ???