Skip to content

[embedded] Add support for actors and async let into the embedded Concurrency runtime #69090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2023
Merged

[embedded] Add support for actors and async let into the embedded Concurrency runtime #69090

merged 1 commit into from
Oct 15, 2023

Conversation

kubamracek
Copy link
Contributor

This PR:

  • expands the same "pass type information via taskOptions" approach done in [embedded] Initial Swift Concurrency for embedded Swift #68928 to async let runtime calls
  • starts building a larger portion of the Swift Concurrency runtime in embedded mode, including Actor.swift
  • adds simple testcases showing actors and async let working in embedded Swift

@kubamracek
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek requested a review from mikeash October 13, 2023 17:10
zoecarver
zoecarver approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kubamracek kubamracek added the embedded Embedded Swift label Oct 14, 2023
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek merged commit 7e9013d into swiftlang:main Oct 15, 2023
@kubamracek
Copy link
Contributor Author

Merging to make progress on getting the experimental implementation of embedded Swift to support Swift Concurrency, but happy to take any post-merge feedback/review comments.

ktoso
ktoso reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks roughly okey; I'm worried about the amount of various "is available here but not there" annotations and combinations but we'll have to somehow holistically find some better strategy someday perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso left review comments

@zoecarver zoecarver zoecarver approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

@rokhinip rokhinip Awaiting requested review from rokhinip

@eeckstein eeckstein Awaiting requested review from eeckstein

@kavon kavon Awaiting requested review from kavon

@mikeash mikeash Awaiting requested review from mikeash

Assignees
No one assigned
Labels
embedded Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubamracek @ktoso @zoecarver