Incorrect location of 'async' for protocol in actor's fix suggestion

[dancamarotto]

Resolves #69244

[LucianoPAlmeida]

@swift-ci Please smoke test

[LucianoPAlmeida]

It looks like this code path was not really covered by tests since nothing broke. So wondering if we could add a few more tests for covering "throws" as well.
But PR looks good, someone from Apple team have the final say before merging :)

[LucianoPAlmeida]

What I meant by throws tests were something like this

import Distributed

protocol P {
    func foo() -> Void // here fix-it is also wrong result in func foo() -> async throws Void
}

distributed actor A: P {
    func foo() { }
}

In this example the fix-it covers throws modifier as well which at the moment is also wrong func foo() -> async throws Void. Note that this test since it requires distributed it has to be on a file that has // REQUIRES: distributed you can search across for examples.

It would be nice, but is not required for this PR I guess, but I'll left that up to someone from the team.

[dancamarotto]

@LucianoPAlmeida ah ok, thanks, I hadn't thought of distributed actors - done. please let me know if it does not look correct.

I tried to add the test so that the only error would be what I wanted to test, hence the typealias ActorSystem and the distributed func.

[LucianoPAlmeida]

@LucianoPAlmeida ah ok, thanks, I hadn't thought of distributed actors - done. please let me know if it does not look correct.

Distributed is the only case where we exercise this async throws fix-it, and test does look right. But I don't recommend adding distributed test to this file. This test should probably be in a file that has // REQUIRES: distributed otherwise I think it would fail on CI.

Maybe add that test case to a file under test/Distributed? The test/Distributed/actor_protocols.swift file seems like a good candidate, but I am no expert in this so my suggestions should be taken with a grain of salt. But let's add it and hear from the final reviewers :)

[ktoso]

@swift-ci please smoke test

[ktoso]

This looks good AFAICS, thank you

[ktoso]

@swift-ci please smoke test

[LucianoPAlmeida]

@swift-ci Please smoke test