Mark libc math shims with always_inline attribute #6956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want these to always be inlined, so mark them with ... always_inline. The compiler happened to do the right thing with them previously, but we shouldn't depend on that. Un-XFAILED the tests on Linux, as I think they should work correctly now. Also added an explicit test that remainder gets inlined as well as sqrt.
|
@swift-ci Please test |
|
Build failed |
I'm not sure why we can't generate and intrinsic on Linux for exp, but I don't have a Linux machine on which to investigate.
|
@swift-ci Please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want these to always be inlined, so mark them with ... always_inline. The compiler happened to do the right thing with them previously, but we shouldn't depend on that.
Un-XFAILED the tests on Linux, as I think they should work correctly now. Also added an explicit test that remainder gets inlined as well as sqrt.
rdar://problem/30043258