[Backtracing] Add a caching wrapper for MemoryReader. #69719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we read many small chunks from the process we're backtracing. If it so happens that it's the local process, that isn't really a big problem, but if it's a remote process, especially on Linux where we have to use the memory server, it's probably a little slow. Fix by adding a caching layer. rdar://117681625
Because the cache uses the page addresses as its keys, we should have a precondition to check that we haven't passed an address within a page. The latter would result in confusing behaviour so it's worth diagnosing up front. rdar://117681625
It turns out that .copyBytes() checks that the source doesn't provide more bytes than the destination will accept. rdar://117681625
When I rebased, I didn't get the FileImageSource code quite right. rdar://117681625
al45tair
added
🍒 release cherry pick
|
@swift-ci Please test |
tomerd
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we read many small chunks from the process we're backtracing. If it so happens that it's the local process, that isn't really a big problem, but if it's a remote process, especially on Linux where we have to use the memory server, it's probably a little slow.
Fix by adding a caching layer.
rdar://117681625