Skip to content

[Compile Time Constant Extraction] Add @extractConstantsFromMembers #69944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 29, 2023
Merged

[Compile Time Constant Extraction] Add @extractConstantsFromMembers #69944

merged 7 commits into from
Nov 29, 2023

Conversation

ApolloZhu
Copy link
Contributor

@ApolloZhu ApolloZhu commented Nov 17, 2023 •
edited
Loading

Add @extractConstantsFromMembers attribute under ExtractConstantsFromMembers experimental feature flag

@ApolloZhu
Copy link
Contributor Author

@swift-ci please smoke test

@ApolloZhu ApolloZhu self-assigned this Nov 17, 2023
@ApolloZhu ApolloZhu changed the title [Compile Time Constant Extraction] Add _ConstExtractable [Compile Time Constant Extraction] Add @ extractConstantsFromMembers Nov 17, 2023
@ApolloZhu ApolloZhu changed the title [Compile Time Constant Extraction] Add @ extractConstantsFromMembers [Compile Time Constant Extraction] Add @extractConstantsFromMembers Nov 17, 2023
@ApolloZhu ApolloZhu changed the title [Compile Time Constant Extraction] Add @extractConstantsFromMembers [Compile Time Constant Extraction] Add @extractConstantsFromMembers Nov 17, 2023
@ApolloZhu ApolloZhu marked this pull request as ready for review November 18, 2023 00:56
@ApolloZhu ApolloZhu requested review from artemcm and removed request for xedin, slavapestov, rintaro, bnbarham, CodaFi, ahoppen, hborla and tshortli November 18, 2023 00:57
@ApolloZhu
Copy link
Contributor Author

@swift-ci please smoke test

artemcm
artemcm reviewed Nov 27, 2023
View reviewed changes
@ApolloZhu ApolloZhu force-pushed the ApolloZhu/const-extract/protocol branch from a9a5574 to dd17bb1 Compare November 28, 2023 23:02
@ApolloZhu
Copy link
Contributor Author

@swift-ci please test

@ApolloZhu ApolloZhu requested a review from artemcm November 29, 2023 02:08
@ApolloZhu ApolloZhu merged commit 9d1a92e into main Nov 29, 2023
@ApolloZhu ApolloZhu deleted the ApolloZhu/const-extract/protocol branch November 29, 2023 16:49
@compnerd
Copy link
Member

Is there an evolution proposal that went along with this? If this is not yet approved, should this not be spelt with a leading _?

@hborla
Copy link
Member

hborla commented Nov 29, 2023

@compnerd SE-0362 standardized the in-development language feature model to use experimental feature flags instead of (or in addition to, depending on the circumstance) the _ attribute spelling: https://github.com/apple/swift-evolution/blob/main/proposals/0362-piecemeal-future-features.md#embracing-experimental-features

@compnerd
Copy link
Member

@hborla might be good to be more explicit about that in the prose. I never realized that was part of the proposal.

@hborla
Copy link
Member

hborla commented Nov 29, 2023

@compnerd That's fair, and we should also include that in the Swift Evolution process document. I'm not sure it's been updated to include mention of experimental features since SE-0362 has been accepted. I'll make that change 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees

@ApolloZhu ApolloZhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ApolloZhu @compnerd @hborla @artemcm