[IRGen] Use memcpy for BitwiseCopyable archetypes. #70112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar96919870/2/typeinfo
branch
from
4de6a96 to
bc95402
Compare
nate-chandler
force-pushed
the
rdar96919870/2/typeinfo
branch
from
bc95402 to
cfae49a
Compare
|
@swift-ci please test |
atrick
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Looks good. This just needs to line up with @kavon's plans for surfacing BitwiseCopyable and we'll probably need to make it available under a production feature before libraries, like swift-collections, can start building on top of it.
|
Let's use the PR mentioned above #69938 that surfaces the protocol and adds a feature flag to discuss those aspects. |
aschwaighofer
approved these changes
Nov 30, 2023
slavapestov
requested changes
Nov 30, 2023
nate-chandler
force-pushed
the
rdar96919870/2/typeinfo
branch
from
cfae49a to
dfb1200
Compare
slavapestov
approved these changes
Nov 30, 2023
nate-chandler
force-pushed
the
rdar96919870/2/typeinfo
branch
2 times, most recently
from
c8cbefe to
7be9457
Compare
|
Yep, added an analogous test for an unaligned load where the archetype is constrained to conform to a protocol derived from BitwiseCopyable. |
|
@swift-ci please test |
nate-chandler
force-pushed
the
rdar96919870/2/typeinfo
branch
from
7be9457 to
ce2b40d
Compare
Similar to the existing variant which takes a fixed size, the new variant which takes a dynamic size digs the relevant address and alignment values out of the Address struct and passes them along.
Besides being an optimization, using memcpy directly rather than a value witness is required in order to interact with unaligned instances of such types: the value witness functions expect their arguments to be aligned. rdar://96919870
nate-chandler
force-pushed
the
rdar96919870/2/typeinfo
branch
from
ce2b40d to
fef7c77
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #69938 . This PR adds two new commits.
Besides being an optimization, using memcpy directly rather than a value witness is required in order to interact with unaligned instances of such types: the value witness functions expect their arguments to be aligned.
rdar://96919870