[5.10] Fix LetPropertiesOpt crash on @_objcImplementation extensions #70115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://115139065 (Swift Compiler; @_objcImplementation; crash in LetPropertiesOpt) (cherry picked from commit 98dabf9)
|
@swift-ci test |
|
@tbkka approval please |
tbkka
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://115139065 (Swift Compiler; @_objcImplementation; crash in LetPropertiesOpt)
(cherry picked from commit 98dabf9)
--- CCC ---
Explanation: LetPropertiesOpts assumes that each property is declared in a nominal type. This is not true with
@_objcImplementation. The previous fix was incomplete: rdar://103381746.Scope: -O build; private @_objcImplementation extension; constant private property
Issue: rdar://115139065 (Swift Compiler Crash; @_objcImplementation; crash in LetPropertiesOpt)
Risk: Zero. Bypass optimization on a condition that would always crash.
PR to main: #70113
Testing: Added regression test to the test suite
Reviewer: @eeckstein