Skip to content

[stdlib] Performance improvements for reading keypaths #70451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 6, 2025
Merged

[stdlib] Performance improvements for reading keypaths #70451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4733da2
Performance improvements for reading keypaths
Azoy Dec 13, 2023
00ace66
Round up sizeWithMaxSize
Azoy Dec 14, 2023
6fdb684
Optimization for single component and fix tests
Azoy Dec 16, 2023
25a4bbe
Check maxSize on finish
Azoy Dec 16, 2023
581376e
Move variable into closure
Azoy Dec 19, 2023
02401d4
Remove some workarounds
Azoy Feb 20, 2024
59c53b7
Don't do the kvc stored offset optimization on 16 bit platforms
Azoy Oct 31, 2024
edee13a
Take the leaf type into account for max size
Azoy Nov 5, 2024
90bd2a0
Add maxSize helper to buffer and fix reroot
Azoy Feb 5, 2025
f38e84c
Pass buffer to _projectReadOnly and fix appends
Azoy Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/public/SwiftShims/swift/shims/KeyPath.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ static const __swift_uint32_t _SwiftKeyPathBufferHeader_TrivialFlag
= 0x80000000U;
static const __swift_uint32_t _SwiftKeyPathBufferHeader_HasReferencePrefixFlag
= 0x40000000U;
static const __swift_uint32_t _SwiftKeyPathBufferHeader_IsSingleComponentFlag
= 0x20000000U;
static const __swift_uint32_t _SwiftKeyPathBufferHeader_ReservedMask
= 0x3F000000U;
= 0x1F000000U;

// Bitfields for a key path component header.

Expand Down
Loading