Skip to content

[CSBindings] Make it possible to enumerate supertypes of existentials #70522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 18, 2023

  • Drop mayHaveSuperclass because it's too restrictive.
  • Add logic to get superclass of existential and re-create
    existential type with all of the protocol requirements.

@xedin xedin requested a review from slavapestov December 18, 2023 19:21
@xedin xedin requested review from ktoso, kavon and hborla as code owners December 18, 2023 19:21
@xedin
Copy link
Contributor Author

xedin commented Dec 18, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Dec 18, 2023

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Dec 18, 2023

@swift-ci please test Windows platform

- Drop `mayHaveSuperclass` because it's too restrictive.
- Add logic to get superclass of existential and re-create
  existential type with all of the protocol requirements.
…existential

Extend existing check to handle type erased versions when they
are wrapped in an existential.
@xedin xedin force-pushed the csbindings-support-superclass-of-existential branch from 9d72530 to a288b1e Compare December 19, 2023 21:37
@xedin
Copy link
Contributor Author

xedin commented Dec 19, 2023

@swift-ci please test

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Dec 20, 2023

@swift-ci please test

@xedin xedin merged commit d540f48 into swiftlang:main Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant