Skip to content

[5.10][IRGen] Disable simple single payload enum in layout strings #70529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Dec 18, 2023

Cherry-pick of: #70528

  • Explanation: There are a few issues with wrong assumptions around extra inhabitants that cause tags to not be identified properly in some cases. Until a proper fix is identified, we emit tag functions instead.
  • Scope: Layout strings
  • Risk: Low, feature is still experimental
  • Testing: Added regression test
  • Issue: rdar://119792426
  • Reviewer: @aschwaighofer

@drexin drexin requested a review from a team as a code owner December 18, 2023 23:52
@drexin
Copy link
Contributor Author

drexin commented Dec 18, 2023

@swift-ci test

@drexin drexin requested a review from tbkka December 18, 2023 23:52
@drexin drexin changed the title [IRGen] Disable simple single payload enum in layout strings [5.10][IRGen] Disable simple single payload enum in layout strings Dec 18, 2023
@drexin drexin added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.10 labels Dec 18, 2023
@drexin drexin force-pushed the wip-disable-simple-enum-5.10 branch from 73f29be to fd5bbe2 Compare December 19, 2023 20:04
@drexin
Copy link
Contributor Author

drexin commented Dec 19, 2023

@swift-ci test

rdar://119792426

There are a few issues with wrong assumptions around extra inhabitants that cause tags to not be identified properly in some cases. Until a proper fix is identified, we emit tag functions instead.
@drexin drexin force-pushed the wip-disable-simple-enum-5.10 branch from fd5bbe2 to 1d8845a Compare December 20, 2023 16:24
@drexin
Copy link
Contributor Author

drexin commented Dec 20, 2023

@swift-ci smoke test

@drexin
Copy link
Contributor Author

drexin commented Dec 20, 2023

@swift-ci test

@drexin drexin merged commit b11899d into swiftlang:release/5.10 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants