[region-isolation] Add support for more instructions. #70562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: I am just adding coverage that we support these instructions. One can only use this with Error today and Error is always Sendable. So this is just going for completeness.
…_ref, index_raw_pointer.
NOTE: This required me to stop using swift::getUnderlyingObject from getUnderlyingTrackedObject since when it stripsCasts it looks through unchecked_trivial_bit_cast... but we only want to do that if both the operand and result of the instruction are non-Sendable. To fix this I inlined getUnderlyingObject's impl and removed that part of stripCasts.
Just followed the model of unchecked_trivial_bit_cast.
Same as unchecked_trivial_bit_cast.
gottesmm
requested review from
slavapestov
and removed request for
ktoso and
kavon
|
@swift-ci smoke test |
|
Slava wants to do post-commit review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding support for more instructions. The only truly interesting change of note is that to handle unchecked_trivial_bit_cast (which we have to handle since RawPointer is considered non-Sendable) I had to inline getUnderlyingObject into getUnderlyingTrackedObject since the former API unconditionally looks through the cast... we can only look through the cast if both the source/dest are non-Sendable.
The instructions I added support for were specifically: