Skip to content

Fix the symbol visibility in Swift compatibility lib into default instead of hidden, solve auto-linking issue and match Apple's behavior #70627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the symbol visibility in Swift compatibility lib into default instead of hidden, solve auto-linking issue and match Apple's behavior #70627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions stdlib/toolchain/Compatibility50/Overrides.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ struct OverrideSection {
#include "CompatibilityOverride.def"
};

// We must ensure visibility become global non-hidden
// because auto-linking from dep dylibs need this symbol
__attribute__((visibility("default")))
OverrideSection Swift50Overrides
__attribute__((used, section("__DATA,__swift_hooks"))) = {
.version = 0,
Expand Down
4 changes: 3 additions & 1 deletion stdlib/toolchain/Compatibility50/Overrides.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ namespace swift {

using ConformsToProtocol_t =
const WitnessTable *(const Metadata *, const ProtocolDescriptor *);

// We must ensure visibility become global non-hidden
// because auto-linking from dep dylibs need this symbol
__attribute__((visibility("default")))
const WitnessTable *
swift50override_conformsToProtocol(const Metadata * const type,
const ProtocolDescriptor *protocol,
Expand Down
3 changes: 3 additions & 0 deletions stdlib/toolchain/Compatibility51/Overrides.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ struct OverrideSection {
#include "CompatibilityOverride.def"
};

// We must ensure visibility become global non-hidden
// because auto-linking from dep dylibs need this symbol
__attribute__((visibility("default")))
OverrideSection Swift51Overrides
__attribute__((used, section("__DATA,__swift51_hooks"))) = {
.version = 0,
Expand Down
4 changes: 3 additions & 1 deletion stdlib/toolchain/Compatibility51/Overrides.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ using ConformsToSwiftProtocol_t =
const ProtocolConformanceDescriptor *(const Metadata * const type,
const ProtocolDescriptor *protocol,
llvm::StringRef moduleName);

// We must ensure visibility become global non-hidden
// because auto-linking from dep dylibs need this symbol
__attribute__((visibility("default")))
const ProtocolConformanceDescriptor *
swift51override_conformsToSwiftProtocol(const Metadata * const type,
const ProtocolDescriptor *protocol,
Expand Down