Skip to content

Assorted small cleanups #70667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 3, 2024
Merged

Assorted small cleanups #70667

merged 10 commits into from
Jan 3, 2024

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Jan 2, 2024 •
edited
Loading

Fixes rdar://problem/119823811

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
AST: Print Pack{ ... } in more debugging contexts
a6c99bd
@slavapestov
AST: Correct '(each T).A' output for archetypes
770e6f9 
isParameterPack() is always false for an archetype; we must test for a
PackArchetypeType here instead.
@slavapestov
AST: Add missing space to printed message in ASTVerifier
e021d38
@slavapestov
AST: Use dumpRef() instead of print() in Witness::dump() to avoid req…
f96ab36 
…uest cycles
@slavapestov
Sema: Tiny cleanup in ConstraintSystem::getTypeOfReference()
fb3ad9a
@slavapestov
Sema: getValueInterfaceType() is getInterfaceType()->getReferenceStor…
635e90b 
…ageReferent()
@slavapestov
SIL: Don't need a GenericEnvironment in isUnsupportedKeyPathValueType()
05dcc4b
@slavapestov
SIL: Correctly form CanPackExpansionType
88c76aa
@slavapestov
IRGen: Fix some formatting in an assertion regarding on-stack pack cl…
9e2123b 
…eanups
@slavapestov
SIL: Fix printing of opaque parameter types
47ca44c 
While printing them as `some P` makes sense in the AST since they
only ever appear at their definition point, in the body of a SIL
function, opaque parameter types can be referenced by various
instructions, like any other generic parameter type.

Instead of printing out `some P` or `<anonymous>` depending on
context, neither of which actually parsed, instead print them
with the canonical type `τ_d_i` notation. Since it's printed this
way in the generic parameter list as well, it parses back in.

Fixes rdar://problem/119823811.
@slavapestov slavapestov force-pushed the assorted-small-cleanups branch from 13feddd to 47ca44c Compare January 2, 2024 20:41
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov merged commit 8e2aa52 into swiftlang:main Jan 3, 2024
@slavapestov slavapestov mentioned this pull request Jan 3, 2024
Merged
@glessard glessard mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slavapestov