[Concurrency] Cleanup of assert/precondition/assume isolated docs #70800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
added
concurrency
ktoso
force-pushed
the
wip-assert-isolated-docs-revamp
branch
from
005070b to
742e483
Compare
|
@swift-ci please smoke test |
|
Linux CI has unrelated issues right now, need to wait it out |
amartini51
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Thanks for this, Konrad! Made some changes to fix odd punctuation and revise wording. Marked each change only the first time, since similar docs are repeated on similar APIs.
I can take another pass tomorrow if you want, to help you follow the style guidance for API reference a little more closely.
Co-authored-by: Alex Martini <amartini@apple.com>
|
Thank you for the review @amartini51 ! |
|
@swift-ci please smoke test |
ktoso
changed the title
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
…cs (swiftlang#70800) Co-authored-by: Alex Martini <amartini@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major revamp of documentation of all the assert / precondition / assume isolated docs.
The docs now explain more about the exact semantics, avoid mentioning behavior that was not actually implemented for the
-Ouncheckedmode, and explain semantics in face of sharing the same serial executor.This should also help understanding in face of task executors -- as we explicitly say that these use the serial executor of actors and not the task executor.
resolves rdar://115729096