Skip to content

[SILOpt] Fix layout based pre-specialization with marker protocols #71038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Jan 20, 2024

Marker protocols can be ignored in the specialization, because they have no witness and the conformance will be checked before the specialization is applied.

Also fixes an issue where multiple requirements on the same type caused type mismatches in the erased signature.

Marker protocols can be ignored in the specialization, because they have no witness and the conformance will be checked before the specialization is applied.

Also fixes an issue where multiple requirements on the same type caused type mismatches in the erased signature.
@drexin drexin requested a review from kavon January 20, 2024 22:05
@drexin
Copy link
Contributor Author

drexin commented Jan 20, 2024

@swift-ci smoke test

Copy link
Member

@kavon kavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@drexin drexin merged commit 6bfbaa1 into swiftlang:main Jan 22, 2024
@drexin drexin deleted the wip-121281438 branch January 22, 2024 16:40
carlos4242 pushed a commit to carlos4242/swift that referenced this pull request May 31, 2024
…wiftlang#71038)

Marker protocols can be ignored in the specialization, because they have no witness and the conformance will be checked before the specialization is applied.

Also fixes an issue where multiple requirements on the same type caused type mismatches in the erased signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants