Skip to content

[CodeComplete] Remove code for call pattern heuristics and ConjunctionElement::mightContainCodeCompletionToken #71081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 23, 2024

These call pattern heuristic options weren’t used anymore, so we can remove them.

ConjunctionElement::mightContainCodeCompletionToken isn’t used anymore (I think it stopped being used after the new result builder transform was enabled).

Isn’t used anymore (I think it stopped being used after the new result builder transform was enabled).
These options weren’t used anymore, so we can remove them.
@ahoppen
Copy link
Member Author

ahoppen commented Jan 23, 2024

@swift-ci Please smoke test

@ahoppen ahoppen merged commit 5e803c6 into swiftlang:main Jan 23, 2024
@ahoppen ahoppen deleted the ahoppen/remove-call-pattern-heuristics branch January 23, 2024 15:38
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants