Skip to content

remove unused declaration attribute IsolatedAttr #71229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

remove unused declaration attribute IsolatedAttr #71229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions include/swift/AST/Attr.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,9 +492,6 @@ SIMPLE_DECL_ATTR(rethrows, Rethrows,
CONTEXTUAL_SIMPLE_DECL_ATTR(indirect, Indirect,
DeclModifier | OnEnum | OnEnumElement | ABIBreakingToAdd | ABIBreakingToRemove | APIStableToAdd | APIStableToRemove,
60)
CONTEXTUAL_SIMPLE_DECL_ATTR(isolated, Isolated,
DeclModifier | OnParam | ABIBreakingToAdd | ABIBreakingToRemove | APIBreakingToAdd | APIBreakingToRemove,
103)
CONTEXTUAL_SIMPLE_DECL_ATTR(async, Async,
DeclModifier | OnVar | OnFunc | ABIBreakingToAdd | ABIBreakingToRemove | APIBreakingToAdd | APIBreakingToRemove,
106)
Expand Down
1 change: 0 additions & 1 deletion lib/Sema/TypeCheckAttr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> {
IGNORED_ATTR(AtReasync)
IGNORED_ATTR(ImplicitSelfCapture)
IGNORED_ATTR(InheritActorContext)
IGNORED_ATTR(Isolated)
IGNORED_ATTR(Preconcurrency)
IGNORED_ATTR(BackDeployed)
IGNORED_ATTR(Documentation)
Expand Down
1 change: 0 additions & 1 deletion lib/Sema/TypeCheckDeclOverride.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,7 +1612,6 @@ namespace {
UNINTERESTING_ATTR(Nonisolated)
UNINTERESTING_ATTR(ImplicitSelfCapture)
UNINTERESTING_ATTR(InheritActorContext)
UNINTERESTING_ATTR(Isolated)
UNINTERESTING_ATTR(NoImplicitCopy)
UNINTERESTING_ATTR(UnavailableFromAsync)

Expand Down
2 changes: 1 addition & 1 deletion lib/Serialization/ModuleFormat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const uint16_t SWIFTMODULE_VERSION_MAJOR = 0;
/// describe what change you made. The content of this comment isn't important;
/// it just ensures a conflict if two people change the module format.
/// Don't worry about adhering to the 80-column limit for this line.
const uint16_t SWIFTMODULE_VERSION_MINOR = 843; // add OSLog string encoding
const uint16_t SWIFTMODULE_VERSION_MINOR = 844; // remove IsolatedAttr

/// A standard hash seed used for all string hashes in a serialized module.
///
Expand Down
2 changes: 1 addition & 1 deletion test/Parse/macro_decl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func test() {
dynamic #someFunc

@CustomAttr
isolated #someFunc
#someFunc
}

public # someFunc // expected-error {{extraneous whitespace between '#' and macro name is not permitted}} {{9-10=}}
Expand Down