[Concurrency] Audit diagnostics for Swift 6. #71244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
force-pushed
the
swift-6-diagnostics
branch
from
9a5e456 to
74c9c99
Compare
…he imported module has enabled Swift 6. Warnings when the client enables Swift 6 are not useful because that's not the point when the library API has been audited.
hborla
force-pushed
the
swift-6-diagnostics
branch
from
74c9c99 to
09432a9
Compare
…` to downgrade or suppress errors until a specified language version.
…iagnostics that are suppressed or downgraded until Swift 6. There are a few benefits to using a `UntilSwiftVersion` diagnostic engine API, including the diagnostic wrapping to communicate that the mistake will be an error in Swift 6, and to include the mistake in the frontend statistic for Swift 6 errors.
hborla
force-pushed
the
swift-6-diagnostics
branch
from
71be559 to
11cb94f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes a few functional changes to strict concurrency diagnostics:
@preconcurrencywarnings should only come back when the imported module has enabled Swift 6. Warnings when the client enables Swift 6 are not useful because that's not the point when the library API has been audited.Sendablediagnostics are errors in Swift 6.This change also adds a new
.limitBehaviorUntilSwiftVersionAPI onInFlightDiagnosticand uses it for all concurrency diagnostics that are suppressed or downgraded until Swift 6. There are a few benefits to using aUntilSwiftVersiondiagnostic engine API, including the diagnostic wrapping to communicate that the mistake will be an error in Swift 6, and to include the mistake in the frontend statistic for Swift 6 errors.