GenericCloner: make sure that we can always specialize in mandatory mode #71314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
…ure-specialized functions We need to keep the original linkage because it would be illegal to call a shared not-serialized function from a serialized function. Also, rename the API to create the specialized function.
This may involve changing the linkage of the specialized function. If called from a serialized function we cannot make the specialized function shared and non-serialized. The only other option is to keep the original function's linkage. rdar://121675461
eeckstein
force-pushed
the
fix-mandatory-specializtion
branch
from
0bdd60a to
874360e
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may involve changing the linkage of the specialized function.
If called from a serialized function we cannot make the specialized function shared and non-serialized.
The only other option is to keep the original function's linkage.
Fixes a crash in embedded mode.
rdar://121675461